CobblemonQuests

[1.6.4] — 2026-04-20 — "Stars via Economy"

Star rewards now dispatch through a configurable economy command (default: eco deposit {amount} stars {player}) so a proper Impactor currency account is what updates — not a parallel JSON ledger. The chat banner on claim is fully configurable from config.conf.

Fixed — Stars never reached the economy plugin

• Previously, star rewards only updated PlayerQuestData.starsBalance in the mod's own JSON. Servers that had configured impactor:stars as a proper Impactor currency in economy.conf saw the mod report "★ +N Stars" in chat while /eco balance stars never moved.
• The new rewards.stars-deposit-command runs a real economy command on every grant. The command's return value is checked — if the template is misconfigured (wrong currency id, missing plugin, typo), the dispatch fails loudly in latest.log with the exact resolved invocation, and the JSON mirror is not incremented. No more silent "stars awarded" with nothing actually delivered.

Added — rewards.stars-* config block

rewards {
  stars-deposit-command  = "eco deposit {amount} {currency} {player}"
  stars-withdraw-command = "eco withdraw {amount} {currency} {player}"
  stars-currency-id      = "stars"
  stars-mirror-balance   = true
}

• Placeholders: {amount} (plain number, no trailing zeros), {player} (unquoted name), {currency} (substitutes stars-currency-id).
• Blank stars-deposit-command = legacy in-JSON-only behaviour (upgrade-safe; servers with no economy plugin still work).
• stars-mirror-balance keeps the local JSON in sync for the in-mod leaderboard, the StatsGui, and the reroll-cost guard. Turn off if you're replacing those UIs with economy-plugin equivalents.

Added — Fully customizable chat banner

rewards {
  notify-stars          = "<yellow>★ +{amount} Stars</yellow>"
  notify-pokedollars    = "<green>$ +{amount} PokeDollars</green>"
  notify-claimed        = "<green>✓ Claimed: <white>{quest}</white></green>"
  notify-bonus-claimed  = ""
  notify-quest-ready    = ""
  notify-quest-complete = ""
}

• notify-stars / notify-pokedollars replace the previously hardcoded chat toasts in RewardDispenser. Blank = suppress.
• notify-claimed (and the three companion keys) override the corresponding notification.* entries in the language JSON when non-blank. Blank = fall through to the language file so translations still work.
• The reference image from the bug report maps to:
  • line 1 = notify-stars
  • line 2 = notify-pokedollars
  • line 3 = notify-claimed

Added — Startup banner for active star backend

• onServerStarted now logs one INFO line identifying which backend is live: either legacy in-JSON or dispatching '<template>' (currency='<id>', mirror=<bool>). Grep latest.log to confirm the mode without opening the config.

Technical notes

• Command dispatch uses the same executeWithPrefix path that RewardDispenser.runCommand uses — withSilent().withLevel(4), with a leading / stripped. The new contract is that result < 1 (no nodes matched) is a hard failure.
• Re-entry guard: a misconfigured command that calls back into the mod's own star-grant path (e.g. questsadmin give ...) is caught by a ThreadLocal guard and logs a WARN instead of stack- overflowing.
• Offline players: if the command can't resolve a name (no online player, no cached PlayerQuestData.playerName), the grant is queued into the existing pendingRewards list and delivered on next join. If Impactor itself accepts offline-name /eco deposit (it does, via the server user cache), grants to offline-but- cached players go through immediately.
• refundStars dispatches the same deposit command but does not increment lifetimeStarsEarned (preserves the v1.6.2 leaderboard contract). Side-effect: Impactor's transaction log can't distinguish refund from earn. Accepted.
• Mirror drift: if an operator runs /eco take stars <player> … directly, the JSON mirror over-reports. Next star grant is still correctly dispatched, so the mirror only drifts until then — no persistent corruption. Admins who care should switch stars-mirror-balance = false and rebuild the leaderboard from their economy plugin.