CombatGunSSS

[2.2.0] - 2026-07-18

Fixed

🔴 GunCommand — Every player-facing subcommand blocked for non-admins (Critical)

• Root cause: onCommand() gated the entire /gun command tree behind combatgun.admin before dispatching to any subcommand, and plugin.yml additionally declared permission: combatgun.admin directly on the command — so Bukkit's own command dispatcher rejected non-admins before onCommand() ever ran. This silently broke /gun buy (the Vault shop), /gun attach / /gun detach / /gun attachments, /gun stats, /gun leaderboard, and /gun recipe for every player without combatgun.admin, even though several of these handlers already contained their own combatgun.use check — a check that could never actually execute.
• Fix: Removed the command-level permission: entry from plugin.yml. onCommand() now checks a new PLAYER_SUBCOMMANDS set — buy, attach, detach, attachments, stats, leaderboard, recipe, the self-service subcommands that take no target-player argument — against combatgun.use OR combatgun.admin. Every other subcommand (give, giveammo, givepart, station, book, givepouch, givethrowable, inspect, reload, statsreset, seasonreset) still requires combatgun.admin, since each of those can act on an arbitrary target player and is not meant to be self-service.

🔴 GunCommand.onTabComplete() — Same admin-only gate hid tab-completion for regular players (High)

• Root cause: Identical bug to the one above — onTabComplete() returned an empty list for any sender without combatgun.admin. Even after fixing onCommand(), non-admins would still see zero suggestions when typing /gun .
• Fix: onTabComplete() now mirrors the PLAYER_SUBCOMMANDS permission split — non-admins with combatgun.use see the subcommand names they're allowed to run, and id-completion for /gun recipe <id> (a read-only lookup) is available to them as well. Argument completion for admin-only give/inspect/config subcommands remains gated behind combatgun.admin.

🟠 VaultHook.buyGun() — Purchased weapon silently lost when inventory is full (Medium)

• Root cause: player.getInventory().addItem(gunItem) was called without checking its return value. addItem() silently drops any ItemStack that doesn't fit, so a player with a full inventory was charged the full price but never actually received the gun.
• Fix: The leftover ItemStacks returned by addItem() are now dropped at the player's feet via dropItemNaturally(), and the player receives an additional chat message letting them know the purchase was dropped rather than lost.

Added

CraftingManager — Recipe Browser split into Gun / Melee / Ammo tabs

• The recipe browser (opened from the Mechanical Crafting Table's book icon) now shows three clickable category tabs in its bottom row instead of one long mixed list, so players can find what they want to craft without scrolling past unrelated items.
• New CraftingManager.BrowserCategory enum (GUN, MELEE, AMMO). Guns and melee weapons are both stored under RecipeData.RecipeKind.GUN internally, so the split is done by checking GunData.isMelee() rather than changing the existing recipe-kind enum — this avoids touching the exhaustive switch on RecipeKind in CustomItemManager.
• Each player's last-viewed tab is remembered in-memory (keyed by UUID) so paging with prev/next stays on the same category instead of resetting to Gun; the cache entry is cleared on PlayerQuitEvent to avoid unbounded growth.
• A category with no recipes configured shows an explicit "No recipes here" placeholder instead of an empty page.
• openRecipeBrowser(Player, int) is preserved for existing call sites and now delegates to a new openRecipeBrowser(Player, int, BrowserCategory) overload.

---