Pokebuilder for Cobblemon

[1.2.2] — 2026-04-16

Added

• /pokebuilder debug (permission pokebuilder.admin.debug, default OP 4) — dumps the full economy state as PokeBuilder sees it: mod version, enabled flag, resolved currency key, currency decimals + default balance + primary flag, the full list of registered Impactor currencies (with which one is primary), and the requesting player's current Account lookup (currency, virtual flag, balance). Paste the output in a support ticket and we can diagnose currency routing issues without needing log access.

Changed

• EconomyHandler.withdraw() / .deposit() are now paranoid. Previously we only checked tx.successful() and returned true / false. Now every transaction:
  • logs the full EconomyResultType (SUCCESS, CANCELLED, NOT_ENOUGH_FUNDS, NO_REMAINING_SPACE, FAILED, INVALID) on failure so you can tell why Impactor rejected it (e.g. another mod cancelling the EconomyTransactionEvent.Pre);
  • verifies that account.currency() matches the currency PokeBuilder asked for — if not, a WARN fires because it's a sign Impactor's internal account routing disagrees with what we think we're hooked to;
  • verifies the balance actually moved by the expected amount after the transaction reports SUCCESS. If Impactor says SUCCESS but the balance delta is wrong (virtual account, cached account, intercepted by another mod), a WARN fires with full details: player, currency, expected amount, before balance, after balance, actual delta.
• EconomyHandler.init() logs the full list of registered currencies whenever the configured currency-id isn't found — so admins can immediately see what key to use instead (impactor:dollars, impactor:stars, mypack:credits, etc.) without having to check Impactor's own config.
• Zero-cost transactions short-circuit. Withdrawing 0 and depositing 0 now return true immediately without touching Impactor. No side effects, cleaner audit log, no confusing "balance unchanged" noise.

Fixed

• Reported by a player: "set currency to stars, the GUI sees stars, but buying things doesn't actually deduct any stars." In 1.2.1 we trusted Impactor's tx.successful() as ground truth for "the balance actually moved." If Impactor returns SUCCESS but another mod's EconomyTransactionEvent.Pre subscriber (or a virtual / cached account) leaves the balance unchanged, we'd audit-log the purchase as successful with a deduction that never happened. The new verification step in withdraw() catches this class of bug explicitly — the transaction still goes through per Impactor's report (we don't second-guess the economy), but the mismatch is WARN-logged with full context so admins can chase the interfering mod / restriction / storage layer.

Notes for server operators

• If you see [PokeBuilder] Withdraw reported SUCCESS but balance delta mismatches! in the log, something in your Impactor stack is intercepting the transaction without honestly reporting it. Common culprits: a mod that subscribes to EconomyTransactionEvent for "free purchase" functionality; a virtual-account setup; Impactor's own transfer restrictions if your currency has transferable = FALSE and another mod is trying to normalize it.
• If you see [PokeBuilder] Account currency mismatch!, please open an issue — that shouldn't happen and probably indicates an Impactor bug or a currency-registration collision.
• /pokebuilder debug is now the first thing to run when anything economy- related feels off. It confirms the live currency binding and shows your player's balance as PokeBuilder reads it — if that balance is different from what /eco balance or your scoreboard shows, the split is between Impactor's backends, not PokeBuilder.