Pokebuilder for Cobblemon

[1.3.3] — 2026-04-16

Fixed

• PCSelectGui crashed every time the player tried to open it with NullPointerException: Cannot invoke "String.isEmpty()" because "$$0" is null from inside Text.literal(null). Cobblemon's PCBox.getName() returns null for boxes the player has never explicitly renamed (which is every box on a fresh PC). I was passing that directly to ItemBuilder.lore() which forwards to Text.literal(). The 1.3.2 diagnostic logging caught it and identified the call site (PCSelectGui.renderBox line 110). Fixed by defaulting to "Box N" when the name is null/blank, and by hardening ItemBuilder.name / lore to no-op or coerce on null inputs so this whole class of bug can't crash a GUI again. Caught in 1.3.2 thanks to cora's follow-up testing.

[1.3.2] — 2026-04-16

Fixed

• Clicking the "Switch to PC" toggle did nothing visible. Root cause was a registry race: BaseGui.open() registered the new GUI in GuiManager before calling player.openHandledScreen(), but openHandledScreen triggers the OLD handler's onClosed callback which calls BaseGui.onClose → GuiManager.unregister(playerId). Because the registry is keyed by player UUID (not by GUI identity), the unregister yanked the freshly-registered new GUI's entry. Fixed by opening the screen first and registering the new GUI after — the old GUI's onClose then unregisters cleanly without colliding with the new entry.
• PC browser layout had slot collisions. The 30 box slots packed into a 5×6 grid overlapped the bottom-bar buttons (BOX_INFO_SLOT 47, PARTY_TOGGLE_SLOT 49, NEXT_SLOT 51) so the last 2 box Pokémon were unreachable and clicking those buttons sometimes triggered a Pokémon-edit instead. New layout puts box slots in a 5×6 grid anchored at row 0 col 1 (slots 1–6, 10–15, 19–24, 28–33, 37–42), reserving row 5 entirely for the bottom bar. Cols 0 / 7 / 8 remain decorative glass walls.

Added

• Diagnostic logging on every PC-open path. PCSelectGui.open, CobblemonBridge.getPC, and the PartySelectGui PC-toggle handler now log every failure with the exception type, player name, and stack trace. If the toggle still fails to open the PC for anyone, the next attempt will leave a clear trail in logs/latest.log — including a chat message to the player naming the failure class.
• BaseGui.open() now wraps build() and onOpen() in try/catch. A misbehaving feature that throws during render no longer leaves the player with a half-attached screen; the failure is logged with the GUI class name and the player keeps their previous screen.