CombatGunSSS

[1.0.1] - 2026-04-05

Fixed

Crafting System

• registerVanillaRecipes() was never called — component recipes were not registered with Bukkit on startup or after /gun reload, so the vanilla Recipe Book showed no entries. Fixed by calling registerVanillaRecipes() in onEnable() and handleReload().
• Best-match recipe resolution — ar_ammo, smg_ammo, and hg_ammo share the same four ingredient types (brass_casing, gunpowder, steel_scrap, primer_cap). The old first-match algorithm could produce the wrong ammo type when a player placed slightly more ingredients than the minimum required. Replaced with a lowest-surplus algorithm that always selects the recipe whose ingredient amounts are closest to what the player put in.
• break only exited the inner loop in registerVanillaRecipes() — when a component recipe required more than 9 items total (the Bukkit ShapelessRecipe cap), the warning was logged but the outer ingredient loop continued, resulting in a partially-built recipe being registered silently. Changed to a labeled break outer so the entire recipe is skipped on overflow.
• Double-click (COLLECT) could pull ingredients out of the Mechanical Crafting Table — Bukkit's COLLECT click type sweeps the entire open inventory for matching items, bypassing the station's input-slot guard and corrupting the crafting preview. Added an explicit ClickType.DOUBLE_CLICK cancel at the top of onInventoryClick.
• Recipe book identified by display name instead of PDC tag — any written_book with "Recipe Guide" in its name would hijack the recipe GUI. The book now carries a recipe_book_marker PDC key set at creation time; RecipeBookListener checks this key instead.
• RecipeCategory.valueOf could throw uncaught IllegalArgumentException — if PDC data was corrupt or written by a different plugin version, the category click handler would crash with an unhandled exception. Wrapped in try-catch with a warning log.

Combat

• Removed 5 [DEBUG] log statements from GunListener.traceProjectile() — these were left in from development and spammed the server console with 4–5 lines per bullet fired.

---